BreakEscape

mirror of https://github.com/cliffe/BreakEscape.git synced 2026-02-20 13:50:46 +00:00

Files

Z. Cliffe Schreuders a52f8da171 docs(rfid): Second review - fix critical conversation pattern error

CRITICAL ISSUE: Planned return-to-conversation pattern was fundamentally incorrect.
Fixed to use proven window.pendingConversationReturn pattern from container minigame.

Key changes:
- NEW: review2/CRITICAL_FINDINGS.md - 8 findings with detailed analysis
- NEW: review2/README.md - Quick action guide
- FIXED: Task 3.4 - Simplified conversation return (2.5h → 1h)
- ADDED: Task 3.9 - returnToConversationAfterRFID function (0.5h)
- FIXED: Section 2c in architecture doc - Correct minimal context pattern
- Updated time estimates: 102h → 101h

npcConversationStateManager handles all conversation state automatically.
No manual Ink story save/restore needed.

Reference: /js/minigames/container/container-minigame.js:720-754

Risk: HIGH → MEDIUM (after fix)
Confidence: 95% → 98%

2025-11-15 23:48:15 +00:00

npc

Add Hostile NPC mode

2025-11-14 19:47:54 +00:00

rails-engine-migration

feat: Implement NPC security guard interaction for lockpicking detection

2025-11-11 01:07:05 +00:00

rfid_keycard

docs(rfid): Second review - fix critical conversation pattern error

2025-11-15 23:48:15 +00:00

room-loading

Add Minigame Documentation: Introduce detailed usage guides for the Container and Notes minigames, outlining features, usage scenarios, and integration with existing systems. Include example data structures and testing instructions to enhance developer understanding and facilitate future enhancements.